Skip to content

Commit bfc1675

Browse files
committed
design-proposal: revise public-IP resource proposal per review
Rework the stub in response to review and maintainer steers: - Rename the kinds PublicIP/PublicIPClaim/PublicIPClass -> IPAddress/ IPAddressClaim/IPAddressClass, in the ipam.cozystack.io group. A class names a pool, and pools are not necessarily public; the resource is the general address. - Drop the "regression, not a wishlist" framing entirely. Cozystack uses kube-ovn only for subnets and VPCs, never its EIP objects, so there is no prior reserve-then-associate capability to preserve. Argue on merits: hold, move, quota, enumerate, bill. - Positioning: standalone-valuable AND part of the Cozystack API surface, both -- precedent etcd-operator.cozystack.io. Designed for clean Cozystack integration without hard-depending on Cozystack machinery. - Rework Security and the worked examples into two honest layers rather than a static invariant. autoAssign:false only stops automatic selection; a Service can still name the pool (metallb.io/address-pool) or pin an IP, and a cluster-admin can impersonate the controller SA past any identity-keyed admission policy. Layer 1 (admission) reduces the blast radius for tenants; layer 2 (reconciliation) turns any collision -- including impersonation -- into a detected IPAddress Conflict rather than silent theft. The cluster-admin/impersonation case is stated as a trust boundary, not handwaved. The VAP also covers pool-select annotations, identifies the controller by ServiceAccount, and allowlists GitOps/system principals so reconciliation is not broken. - Add a section on allocator-first allocation: MetalLB assigns an address the moment it sees a Service, before any claim exists, so the controller must also reconcile Service -> inventory after the fact. Commit only to eventual consistency; note the volumeClaimTemplate analogy is weak because an IP is non-fungible and the allocator does not wait for our controller. - Status schema is a list (dual-stack), addressing the scalar-field gap. - Defer multiple platform-owned addresses per workload as out of scope, with a note that the case may not be real (a router/VPN VM's extra addresses live on a tunnel the platform neither owns nor sees). - Add a Naming note on the IPAddress overlap with core (KEP-1880) and Cluster API IPAM. Assisted-By: Claude Opus 4.8 Signed-off-by: Timofei Larkin <[email protected]>
1 parent e21ca09 commit bfc1675

1 file changed

Lines changed: 305 additions & 105 deletions

File tree

0 commit comments

Comments
 (0)