Increase quote verification gas limit#4261
Merged
MartinquaXD merged 2 commits intomainfrom Mar 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request makes the gas limit for quote verification configurable, increasing the default value. The implementation correctly threads the new configuration through the system. I've found a couple of minor issues related to a comment and a log message that could be improved for clarity and correctness.
squadgazzz
approved these changes
Mar 13, 2026
jmg-duarte
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some insanely complicated quotes exceed the hardcoded 12M gas limit on the simulation. I'm not sure why originally picked the very big but not the highest possible value of 8M which we later bumped to 12M.
Changes
This PR now makes this value configurable and sets the default to ethereum's maximum amount of gas a single tx may consume.
Any quote that needs more gas than this can definitely not be included in an ethereum block.