Skip to content

Increase quote verification gas limit#4261

Merged
MartinquaXD merged 2 commits intomainfrom
increase-quote-verification-gas-limit
Mar 13, 2026
Merged

Increase quote verification gas limit#4261
MartinquaXD merged 2 commits intomainfrom
increase-quote-verification-gas-limit

Conversation

@MartinquaXD
Copy link
Copy Markdown
Contributor

Description

Some insanely complicated quotes exceed the hardcoded 12M gas limit on the simulation. I'm not sure why originally picked the very big but not the highest possible value of 8M which we later bumped to 12M.

Changes

This PR now makes this value configurable and sets the default to ethereum's maximum amount of gas a single tx may consume.
Any quote that needs more gas than this can definitely not be included in an ethereum block.

@MartinquaXD MartinquaXD requested a review from a team as a code owner March 13, 2026 07:27
@MartinquaXD MartinquaXD added the hotfix Labels PRs that should be applied into production right away label Mar 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request makes the gas limit for quote verification configurable, increasing the default value. The implementation correctly threads the new configuration through the system. I've found a couple of minor issues related to a comment and a log message that could be improved for clarity and correctness.

Comment thread crates/price-estimation/src/lib.rs
Comment thread crates/price-estimation/src/lib.rs Outdated
@MartinquaXD MartinquaXD added this pull request to the merge queue Mar 13, 2026
Merged via the queue into main with commit e20bca0 Mar 13, 2026
19 checks passed
@MartinquaXD MartinquaXD deleted the increase-quote-verification-gas-limit branch March 13, 2026 08:58
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hotfix Labels PRs that should be applied into production right away

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants