Skip to content

Retry on OverlappingFileLockException#3318

Merged
alexarchambault merged 1 commit intocoursier:mainfrom
eed3si9n:wip/windows-filelock-issue
Feb 24, 2025
Merged

Retry on OverlappingFileLockException#3318
alexarchambault merged 1 commit intocoursier:mainfrom
eed3si9n:wip/windows-filelock-issue

Conversation

@eed3si9n
Copy link
Copy Markdown
Contributor

Fixes #3267

Problem

On Windows, Coursier is hitting OverlappingFileLockException reliably in some repos. It seems like the the function in question has a retry logic, but OverlappingFileLockException is not checked.

Solution

This catches OverlappingFileLockException, so it will be retried.

**Problem**
On Windows, Coursier is hitting OverlappingFileLockException reliably in some repos.
It seems like the the function in question has a retry logic,
but OverlappingFileLockException is not checked.

**Solution**
This catches OverlappingFileLockException, so it will be retried.
Copy link
Copy Markdown
Member

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eed3si9n!

@alexarchambault alexarchambault merged commit 48288e3 into coursier:main Feb 24, 2025
27 checks passed
@eed3si9n eed3si9n deleted the wip/windows-filelock-issue branch February 24, 2025 23:25
eed3si9n added a commit to eed3si9n/sbt-coursier that referenced this pull request Mar 16, 2025
See also coursier/coursier#3318

**Problem**
1. On Windows, Coursier is hitting OverlappingFileLockException reliably in some repos.
2. I'm currently unable to bump Coursier due to another bug.

**Solution**
Retry from lm-coursier side.
eed3si9n added a commit to eed3si9n/sbt-coursier that referenced this pull request Mar 16, 2025
See also coursier/coursier#3318

**Problem**
1. On Windows, Coursier is hitting OverlappingFileLockException reliably in some repos.
2. I'm currently unable to bump Coursier due to another bug.

**Solution**
Retry from lm-coursier side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting OverlappingFileLockException for Windows in Github actions

2 participants