Case-insensitive OS activation#2286
Merged
alexarchambault merged 4 commits intocoursier:masterfrom Mar 15, 2022
Merged
Conversation
Member
alexarchambault
left a comment
alexarchambault
left a comment
There was a problem hiding this comment.
Thanks! It looks like this needs to be fixed, yes.
I think I'd prefer to keep the arch / family / … as is in the Activation.Os class, and only convert things to lower case in its isActive method (maybe keeping lower case values as private lazy vals in Activation.Os). Some people use the POM parsing capabilities of coursier, and I'd rather keep the original values for them, just in case.
Contributor
Author
|
I did as you suggested so that we preserve the original |
dwickern
commented
Feb 11, 2022
| def isEmpty: Boolean = | ||
| arch.isEmpty && families.isEmpty && name.isEmpty && version.isEmpty | ||
|
|
||
| def archMatch(current: Option[String]): Boolean = |
Contributor
Author
There was a problem hiding this comment.
Do we need to keep this for compatibility since it's public?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This profile does not activate due to the capital W in Windows:
For my use-case, jvmbrotli uses profiles to pull in its jni libs for each operating system:
https://github.com/nixxcode/jvm-brotli/blob/06a73890dec39b060c80d021a45e80c8ae1a8c32/jvmbrotli/pom.xml#L18-L33
This works for
<family>unix</family>and<family>mac</family>but not<family>Windows</family>due to the capitalization:https://github.com/dwickern/sbt-web-brotli/runs/4423716589?check_suite_focus=true