Skip to content

Commit 9a60704

Browse files
GeorgNeisV8 LUCI CQ
authored andcommitted
[compiler] Gracefully handle an unsupported situation
... by skipping the optimization instead of CHECK-failing. Bug: v8:12188 Change-Id: I6709bf1c55506f3d12886efbfbb9934788cd02ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148132 Auto-Submit: Georg Neis <[email protected]> Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/main@{#76741}
1 parent a5f31d0 commit 9a60704

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/objects/lookup.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,8 +1527,8 @@ base::Optional<PropertyCell> ConcurrentLookupIterator::TryGetPropertyCell(
15271527
DisallowGarbageCollection no_gc;
15281528

15291529
Map holder_map = holder->map();
1530-
CHECK(!holder_map.is_access_check_needed());
1531-
CHECK(!holder_map.has_named_interceptor());
1530+
if (holder_map.is_access_check_needed()) return {};
1531+
if (holder_map.has_named_interceptor()) return {};
15321532

15331533
GlobalDictionary dict = holder->global_dictionary(kAcquireLoad);
15341534
base::Optional<PropertyCell> cell =

0 commit comments

Comments
 (0)