Reland "Merged: [compiler] Always record constness dependency for FastDataConstant"

GeorgNeis · V8 LUCI CQ · commit 73666e3f6d6b · 2021-06-04T11:09:57.000Z
This is a reland of 638d1b2 after a one-character change. A local variable still has a non-optional type in this version of V8. Original change's description: > Merged: [compiler] Always record constness dependency for FastDataConstant > > Revision: 1bfa513 > > BUG=chromium:1209558 > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > > Change-Id: If4f7243647bcc12ed482796c1353f0717630f6b9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919823 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/branch-heads/9.1@{v8#59} > Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} > Cr-Branched-From: f565e72-refs/heads/master@{#73847} NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Bug: chromium:1209558 Change-Id: I0c81353882b0f17942fd92ad4181732f941bcb1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939991 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/branch-heads/9.1@{v8#63} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}
diff --git a/src/compiler/access-info.cc b/src/compiler/access-info.cc
@@ -1117,7 +1117,7 @@ PropertyAccessInfo AccessInfoFactory::LookupTransition(
   // Transitioning stores *may* store to const fields. The resulting
   // DataConstant access infos can be distinguished from later, i.e. redundant,
   // stores to the same constant field by the presence of a transition map.
-  switch (details.constness()) {
+  switch (dependencies()->DependOnFieldConstness(transition_map_ref, number)) {
     case PropertyConstness::kMutable:
       return PropertyAccessInfo::DataField(
           zone(), map, std::move(unrecorded_dependencies), field_index,
