Skip to content

Commit 022b312

Browse files
GeorgNeisV8 LUCI CQ
authored andcommitted
[heap] Don't assume that optimizing-compile-dispatcher exists
Bug: chromium:1215514, chromium:1211215 Change-Id: I6ebc1d4138d6bee66c3fd9a8369741b8df960807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933663 Commit-Queue: Georg Neis <[email protected]> Commit-Queue: Dominik Inführ <[email protected]> Auto-Submit: Georg Neis <[email protected]> Reviewed-by: Dominik Inführ <[email protected]> Cr-Commit-Position: refs/heads/master@{#74929}
1 parent f1304bb commit 022b312

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

src/heap/heap.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3165,7 +3165,10 @@ bool Heap::CanMoveObjectStart(HeapObject object) {
31653165
if (IsLargeObject(object)) return false;
31663166

31673167
// Compilation jobs may have references to the object.
3168-
if (isolate()->optimizing_compile_dispatcher()->HasJobs()) return false;
3168+
if (isolate()->concurrent_recompilation_enabled() &&
3169+
isolate()->optimizing_compile_dispatcher()->HasJobs()) {
3170+
return false;
3171+
}
31693172

31703173
// We can move the object start if the page was already swept.
31713174
return Page::FromHeapObject(object)->SweepingDone();
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
// Copyright 2021 the V8 project authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
// Flags: --no-concurrent-recompilation
6+
7+
new Array(4242).shift();

0 commit comments

Comments
 (0)