Skip to content

Commit 0ecc780

Browse files
committed
JSCBC-1358: Update SDK Build Setup
Changes ======= * Update C++ Core * Update CMakeLists.txt to handle C++ core changes Change-Id: I4445b0b33faa9d15e33231329e06ba42fd1d0356 Reviewed-on: https://review.couchbase.org/c/couchnode/+/232812 Reviewed-by: Mateusz <[email protected]> Tested-by: Jared Casey <[email protected]>
1 parent 07667f9 commit 0ecc780

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ if(CMAKE_JS_VERSION VERSION_GREATER_EQUAL "7.0.0")
140140
else()
141141
set(NODEJS_INC_DIR "${CMAKE_JS_INC}")
142142
endif()
143+
list(REMOVE_DUPLICATES NODEJS_INC_DIR)
143144

144145
message(STATUS "NODEJS_INC_DIR=${NODEJS_INC_DIR}")
145146
message(STATUS "NODEJS_LIB=${NODEJS_LIB}")
@@ -151,7 +152,7 @@ if(WIN32)
151152
endif()
152153

153154
# We need to import headers globally for our dependant libraries such as couchbase-cxx-client.
154-
include_directories(${NODEJS_INC_DIR})
155+
include_directories(SYSTEM ${NODEJS_INC_DIR})
155156

156157
get_couchnode_version()
157158
message(STATUS "COUCHNODE_VERSION=${COUCHNODE_VERSION}")
@@ -229,7 +230,7 @@ set_target_properties(${PROJECT_NAME} PROPERTIES PREFIX "" SUFFIX ".node")
229230

230231
target_link_libraries(${PROJECT_NAME}
231232
${NODEJS_LIB}
232-
couchbase_cxx_client::couchbase_cxx_client_static
233+
couchbase_cxx_client_static_intermediate
233234
asio
234235
Microsoft.GSL::GSL
235236
taocpp::json

deps/couchbase-cxx-client

0 commit comments

Comments
 (0)