PCBC-1053: Fix CC compiler flags bleeding into CMAKE_C_COMPILER on macOS#251
Merged
avsej merged 1 commit intocouchbase:mainfrom Mar 27, 2026
Merged
Conversation
phpize on macOS can set CC to a compound string like 'cc -std=gnu23', concatenating the standard flag directly onto the compiler path. CMake rejects this as CMAKE_C_COMPILER because it is not a bare path. Apply the same flag-stripping logic that already existed for CXX to CC as well: detect when CC contains flags, extract the bare path into CC_PATH, substitute it back, and pass CC_PATH directly to -DCMAKE_C_COMPILER in Makefile.frag instead of relying on the GNU make function.
avsej
force-pushed
the
PCBC-1053-fix-macos-build
branch
from
d423453 to
3b068f7
Compare
DemetrisChr
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpize on macOS can set CC to a compound string like 'cc -std=gnu23', concatenating the standard flag directly onto the compiler path. CMake rejects this as CMAKE_C_COMPILER because it is not a bare path.
Apply the same flag-stripping logic that already existed for CXX to CC as well: detect when CC contains flags, extract the bare path into CC_PATH, substitute it back, and pass CC_PATH directly to -DCMAKE_C_COMPILER in Makefile.frag instead of relying on the
GNU make function.