PCBC-1040: Tracing - include child spans created by the C++ core#249
Merged
avsej merged 5 commits intocouchbase:mainfrom Apr 1, 2026
Merged
PCBC-1040: Tracing - include child spans created by the C++ core#249avsej merged 5 commits intocouchbase:mainfrom
avsej merged 5 commits intocouchbase:mainfrom
Conversation
DemetrisChr
changed the title
avsej
force-pushed
the
PCBC-1040-core-spans
branch
from
b92a4dd to
2f50a3e
Compare
avsej
reviewed
Mar 24, 2026
avsej
reviewed
Mar 24, 2026
avsej
reviewed
Mar 24, 2026
avsej
reviewed
Mar 24, 2026
avsej
requested changes
Mar 24, 2026
Member
avsej
left a comment
avsej
left a comment
There was a problem hiding this comment.
I think bufferCoreSpans should return false when tracing is disabled.
DemetrisChr
force-pushed
the
PCBC-1040-core-spans
branch
from
2f50a3e to
fd35498
Compare
DemetrisChr
force-pushed
the
PCBC-1040-core-spans
branch
from
fd35498 to
112f633
Compare
Contributor
Author
|
I've pushed one more patch, adding the |
avsej
approved these changes
Mar 27, 2026
DemetrisChr
force-pushed
the
PCBC-1040-core-spans
branch
from
112f633 to
a8ffc68
Compare
avsej
previously approved these changes
Mar 31, 2026
DemetrisChr
force-pushed
the
PCBC-1040-core-spans
branch
from
7c32c81 to
8d3a82b
Compare
avsej
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.