PCBC-1052: Initialize timeout to null in search/collection mgmt options blocks#247
Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom Mar 11, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a minor but important initialization issue: in 18 Options classes under Couchbase/Management/, the private ?int $timeoutMilliseconds property was declared without an explicit default value. While PHP implicitly treats uninitialized properties as unset (which can trigger deprecation warnings or errors in strict contexts), the fix aligns these classes with the rest of the codebase and ensures consistent, predictable behavior.
Changes:
- Adds
= nullto the$timeoutMillisecondsproperty declaration in 11 search index management options classes and 7 collection/scope management options classes.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Couchbase/Management/AllowQueryingSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/AnalyzeDocumentOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/CreateCollectionOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/CreateScopeOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/DisallowQueryingSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/DropCollectionOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/DropScopeOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/DropSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/FreezePlanSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/GetAllScopesOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/GetAllSearchIndexesOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/GetIndexedSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/GetSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/PauseIngestSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/ResumeIngestSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/UnfreezePlanSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/UpdateCollectionOptions.php |
Initialize $timeoutMilliseconds = null |
Couchbase/Management/UpsertSearchIndexOptions.php |
Initialize $timeoutMilliseconds = null |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Matt-Woz
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.