PCBC-1038, PCBC-1039: Add tracing & metrics instrumentation for management operations#244
Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom Mar 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds observability (tracing spans + metrics) around HTTP-based management operations across multiple manager classes, and introduces/extends test coverage to validate emitted spans/metrics for these operations.
Changes:
- Wrap management operations in
ObservabilityContext::recordOperation(...)to emit spans/metrics and attach service/bucket/scope/collection context. - Propagate
ObservabilityContextinto manager instances created fromCluster,Bucket,Collection, andScope. - Add
ObservabilityHttpMgmtOperationsTestand initialize several typed option properties tonullto avoid uninitialized-property issues.
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ObservabilityHttpMgmtOperationsTest.php | New tests asserting spans + metrics for several HTTP management operations. |
| Couchbase/Scope.php | Passes observability context into scope-level search index manager. |
| Couchbase/Cluster.php | Passes observability context into cluster-level management managers. |
| Couchbase/Bucket.php | Passes observability context into bucket-level collection manager. |
| Couchbase/Collection.php | Passes observability context into collection-level query index manager. |
| Couchbase/Management/BucketManager.php | Wraps bucket management operations with observability. |
| Couchbase/Management/CollectionManager.php | Wraps collection/scope management operations with observability. |
| Couchbase/Management/UserManager.php | Wraps user/group management operations with observability. |
| Couchbase/Management/QueryIndexManager.php | Wraps query index management operations with observability; ensures watchIndexes creates nested spans for polling. |
| Couchbase/Management/CollectionQueryIndexManager.php | Wraps collection-level query index management operations with observability. |
| Couchbase/Management/SearchIndexManager.php | Wraps search index management operations with observability. |
| Couchbase/Management/ScopeSearchIndexManager.php | Wraps scope-level search index management operations with observability. |
| Couchbase/Management/AnalyticsIndexManager.php | Wraps analytics index management operations with observability. |
| Couchbase/Management/GetAllScopesOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/CreateScopeOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/DropScopeOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/CreateCollectionOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/DropCollectionOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/UpdateCollectionOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/GetAllSearchIndexesOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/GetSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/GetIndexedSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/UpsertSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/DropSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/PauseIngestSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/ResumeIngestSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/AllowQueryingSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/DisallowQueryingSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/FreezePlanSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/UnfreezePlanSearchIndexOptions.php | Initializes typed timeout property to null. |
| Couchbase/Management/AnalyzeDocumentOptions.php | Initializes typed timeout property to null. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Matt-Woz
reviewed
Mar 10, 2026
DemetrisChr
force-pushed
the
tracing-metrics-mgmt
branch
from
509e872 to
2d4f892
Compare
Matt-Woz
previously approved these changes
Mar 11, 2026
Contributor
Matt-Woz
left a comment
Matt-Woz
left a comment
There was a problem hiding this comment.
LGTM, just a small question
DemetrisChr
force-pushed
the
tracing-metrics-mgmt
branch
from
2d4f892 to
3ebd8f6
Compare
Matt-Woz
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes