PCBC-1050: Add missing manager accessors in Cluster/Bucket/Collection interfaces#243
Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom Feb 27, 2026
Conversation
DemetrisChr
requested review from
Matt-Woz,
avsej and
Copilot
and removed request for
avsej and
Copilot
There was a problem hiding this comment.
Pull request overview
This PR updates the public ClusterInterface, BucketInterface, and CollectionInterface to expose the full set of manager accessors already available in concrete implementations, and introduces a dedicated AnalyticsIndexManagerInterface to align analytics index management with the rest of the management APIs.
Changes:
- Add missing manager accessor methods to
ClusterInterface,BucketInterface, andCollectionInterface. - Introduce
AnalyticsIndexManagerInterfaceand makeAnalyticsIndexManagerimplement it. - Update the Protostellar
Clusterimplementation to satisfy the expandedClusterInterface(unsupported operations currently throw).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Couchbase/Protostellar/Cluster.php | Adds setAuthenticator(), users(), analyticsIndexes() to match ClusterInterface (currently throws unsupported). |
| Couchbase/Management/AnalyticsIndexManagerInterface.php | New interface defining the analytics index management surface area. |
| Couchbase/Management/AnalyticsIndexManager.php | Declares implementation of the new AnalyticsIndexManagerInterface. |
| Couchbase/CollectionInterface.php | Adds queryIndexes() accessor for collection-level query index management. |
| Couchbase/ClusterInterface.php | Adds missing manager accessors for buckets/users/analytics/query/search index management. |
| Couchbase/BucketInterface.php | Adds collections() accessor for collection/scope management. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
avsej
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes