Update regex for parsing curl.se Mozilla certs header date#907
Merged
thejcfactor merged 2 commits intocouchbase:mainfrom Mar 19, 2026
Merged
Conversation
avsej
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CMake logic that extracts the “as of / last updated” date from the curl.se Mozilla CA bundle header when embedding certificates during the build.
Changes:
- Broaden the header regex to match both “as of” and “last updated on”.
- Update the capture group used to populate
COUCHBASE_CXX_CLIENT_MOZILLA_CA_BUNDLE_DATE.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Looks good. |
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
avsej
approved these changes
Mar 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.