CXXCBC-774: Fix incorrect use of std::move on const Document& parameter#903
Merged
avsej merged 1 commit intocouchbase:mainfrom Mar 13, 2026
Conversation
Changed upsert(), insert(), and replace() to take Document by value instead of const Document&. This correctly supports: - lvalues → copied (backward compatible) - rvalues → moved (was broken before) The previous signature const Document& with std::move() internally caused compilation errors since std::move on a const lvalue produces an rvalue reference that cannot bind to non-const lvalue parameters.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes move semantics for the public KV mutation APIs on couchbase::collection by changing the templated upsert(), insert(), and replace() overloads to take Document by value, enabling correct copy behavior for lvalues and move behavior for rvalues.
Changes:
- Update
collection::upsert()templated future-returning overload to takeDocumentby value. - Update
collection::insert()templated future-returning overload to takeDocumentby value. - Update
collection::replace()templated future-returning overload to takeDocumentby value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
brett19
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed upsert(), insert(), and replace() to take Document by value instead of const Document&. This correctly supports:
The previous signature const Document& with std::move() internally caused compilation errors since std::move on a const lvalue produces an rvalue reference that cannot bind to non-const lvalue parameters.