CXXCBC-731: Correctly apply the wan_development profile in tests when required#835
Merged
avsej merged 1 commit intocouchbase:mainfrom Sep 23, 2025
Merged
Conversation
avsej
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Many tests create cluster connection by using
couchbase::cluster::connectdirectly.test_context::build_options()is also not applying the wan_development profile when the env variable is set. This can lead to timeouts when running tests in slow environments (e.g. valgrind)Changes
integration_test_guard::public_cluster()wherever possibletest_context::build_options()to correctly check for the WAN developement env variable, so that clusters created viapublic_cluster()have it.couchbase::cluster::connectdirectly to apply the profile when needed.