CXXCBC-668: ensure random generator is initialized in websocket_codec#739
Merged
avsej merged 1 commit intocouchbase:mainfrom Mar 21, 2025
Conversation
In some cases, when websocket_code is the first ever to touch RandomGenerator, the library might crash trying to dereference null pointer. It does not happen often, but in case of the one-shot applications it might happen (for example 'cbc get' from the tools)
DemetrisChr
approved these changes
Mar 21, 2025
avsej
deleted the
CXXCBC-668-initialize-random-generator-in-websocket_codec
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, when websocket_code is the first ever to touch RandomGenerator, the library might crash trying to dereference null pointer. It does not happen often, but in case of the one-shot applications it might happen (for example 'cbc get' from the tools)