CXXCBC-633: ensure DNS-SRV resolver reports timeouts#703
Merged
avsej merged 1 commit intocouchbase:mainfrom Dec 9, 2024
Merged
CXXCBC-633: ensure DNS-SRV resolver reports timeouts#703avsej merged 1 commit intocouchbase:mainfrom
avsej merged 1 commit intocouchbase:mainfrom
Conversation
* catch asio::error::operation_aborted in every handler, and return immediately giving chance to deadline_ handler to report timeout error code * make sure that UDP round will always fallback to TCP in case of UDP timeout.
thejcfactor
approved these changes
Dec 9, 2024
Contributor
thejcfactor
left a comment
thejcfactor
left a comment
There was a problem hiding this comment.
Nice! Checked out in the Node.js client. Much better now. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catch
asio::error::operation_abortedin every handler, and return immediately giving chance to deadline_ handler to report timeout error codemake sure that UDP round will always fallback to TCP in case of UDP timeout.