Skip to content

CXXCBC-627: Performance degradation after couchbase::error changes#693

Merged
Matt-Woz merged 1 commit intocouchbase:mainfrom
Matt-Woz:CXXCBC-627_make_error_performance
Nov 6, 2024
Merged

CXXCBC-627: Performance degradation after couchbase::error changes#693
Matt-Woz merged 1 commit intocouchbase:mainfrom
Matt-Woz:CXXCBC-627_make_error_performance

Conversation

@Matt-Woz
Copy link
Copy Markdown
Contributor

@Matt-Woz Matt-Woz commented Nov 4, 2024

Changes:

  • Only run build_error_context if the std::error_code is non-zero

@Matt-Woz Matt-Woz force-pushed the CXXCBC-627_make_error_performance branch from cba6853 to e17bb81 Compare November 4, 2024 17:00
@Matt-Woz Matt-Woz force-pushed the CXXCBC-627_make_error_performance branch 2 times, most recently from dcd912e to ae6e068 Compare November 4, 2024 18:12
@Matt-Woz Matt-Woz force-pushed the CXXCBC-627_make_error_performance branch from ae6e068 to 64a16cf Compare November 4, 2024 18:52
@Matt-Woz Matt-Woz merged commit 24c6576 into couchbase:main Nov 6, 2024
@Matt-Woz Matt-Woz deleted the CXXCBC-627_make_error_performance branch November 6, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants