CXXCBC-616: Columnar - report retry information when receiving a timeout from the HTTP component#681
Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom Oct 16, 2024
Conversation
…out from the HTTP component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have client-side timeouts both for the overall query and for each individual HTTP operation, and it appears possible that the individual HTTP timeout gets triggered before the overall query one and we lose all the error context retry information (last errors, number of retry attempts).
We should handle a timeout error code coming from the HTTP component, and report the same retry fields in the error context that we would otherwise do.