CXXCBC-577: Reduce duplicated code in http_component#657
Merged
avsej merged 2 commits intocouchbase:mainfrom Sep 16, 2024
Merged
CXXCBC-577: Reduce duplicated code in http_component#657avsej merged 2 commits intocouchbase:mainfrom
avsej merged 2 commits intocouchbase:mainfrom
Conversation
DemetrisChr
force-pushed
the
CXXCBC-577-http-comp-dry
branch
from
d6d54c3 to
9c68648
Compare
DemetrisChr
requested review from
avsej and
thejcfactor
and removed request for
thejcfactor
DemetrisChr
force-pushed
the
CXXCBC-577-http-comp-dry
branch
from
9c68648 to
1fa177b
Compare
DemetrisChr
force-pushed
the
CXXCBC-577-http-comp-dry
branch
from
1fa177b to
48b44df
Compare
avsej
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to add a buffered HTTP request method to add support for management operations. This PR removes some of the existing duplication in the HTTP component, to make it easier to do that.