CXXCBC-596: do not include tao_json_serializer.hxx by default#656
Merged
avsej merged 1 commit intocouchbase:mainfrom Sep 16, 2024
Merged
Conversation
avsej
force-pushed
the
CXXCBC-596-make-tao-json-optional-in-public-headers
branch
from
4bba92d to
8cbc228
Compare
thejcfactor
approved these changes
Sep 16, 2024
Contributor
thejcfactor
left a comment
thejcfactor
left a comment
There was a problem hiding this comment.
LGTM 👍
The removal of rows_as_json() in analytics_result/query_result is unfortunate, but understandable w.r.t. the change. Arguably a worthwhile "sacrifice".
Lets just make sure we mention the change in release notes.
avsej
deleted the
CXXCBC-596-make-tao-json-optional-in-public-headers
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thejcfactor, @DemetrisChr, @Matt-Woz this patch will likely require depending projects (like FIT, wrappers etc) to explicitly require
tao/json.hpporcouchbase/codec/tao_json_serializer.hxxBut on the other hand, it allows users to use public API without tao/json with some other serializer, leaving tao/json as only dependency of the C++SDK itself.
This patch is necessary step in producing better packages.