Skip to content

CXXCBC-552: cleanup network selection options#651

Merged
avsej merged 1 commit intocouchbase:mainfrom
avsej:CXXCBC-552-cleanup-network-options
Sep 3, 2024
Merged

CXXCBC-552: cleanup network selection options#651
avsej merged 1 commit intocouchbase:mainfrom
avsej:CXXCBC-552-cleanup-network-options

Conversation

@avsej
Copy link
Copy Markdown
Member

@avsej avsej commented Aug 29, 2024

Deprecates behavior_options#network() in favor to network_options#preferred_network()

@avsej avsej requested review from a team, DemetrisChr and thejcfactor August 29, 2024 22:00
Comment thread couchbase/behavior_options.hxx Outdated
@avsej avsej force-pushed the CXXCBC-552-cleanup-network-options branch from 8b7f6d3 to 661935b Compare August 30, 2024 22:12
Deprecates behavior_options#network() in favor to
network_options#preferred_network()
@avsej avsej force-pushed the CXXCBC-552-cleanup-network-options branch from 661935b to 2e8987b Compare August 30, 2024 22:13
@avsej
Copy link
Copy Markdown
Member Author

avsej commented Aug 30, 2024

@DemetrisChr I've update the patch according to your comment

Comment thread core/impl/cluster.cxx
@avsej avsej requested a review from DemetrisChr September 3, 2024 16:32
@avsej avsej merged commit 1f0243d into couchbase:main Sep 3, 2024
@avsej avsej deleted the CXXCBC-552-cleanup-network-options branch September 3, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants