CXXCBC-562: (Columnar) Provide HTTP session manager with updated cluster#638
Merged
thejcfactor merged 1 commit intocouchbase:mainfrom Jul 26, 2024
Merged
CXXCBC-562: (Columnar) Provide HTTP session manager with updated cluster#638thejcfactor merged 1 commit intocouchbase:mainfrom
thejcfactor merged 1 commit intocouchbase:mainfrom
Conversation
options Motivation ========== After bootstrap completes, for alternate addressing, cluster options can be updated. However, currently for the Columnar connection path those cluster options are not propagated to the HTTP session manager. The lack of propagation means HTTP connections are not able to connect when using alternate addressing because the external hostname and/or port is not used. Changes ======= * For Columnar connections, pass the updated cluster options back in the create_sessions() callback so that the options can be propagated to the HTTP session manager.
avsej
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After bootstrap completes, for alternate addressing, cluster options can be updated. However, currently for the Columnar connection path those cluster options are not propagated to the HTTP session manager. The lack of propagation means HTTP connections are not able to connect when using alternate addressing because the external hostname and/or port is not used.
Changes