Fix behaviour when reading is complete before returning HTTP streaming resp#624
Merged
DemetrisChr merged 2 commits intocouchbase:mainfrom Jul 11, 2024
Merged
Conversation
avsej
reviewed
Jul 11, 2024
avsej
reviewed
Jul 11, 2024
Co-authored-by: Sergey Avseyev <[email protected]>
avsej
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If the entire HTTP body has been read in the initial read before returning the HTTP streaming response, any subsequent attempt to read from the TCP socket will never return.
Changes
reading_completewhen initializinghttp_streaming_response_bodywith the value ofhttp_streaming_parser'scompletefield.stream_end_handlerwhen the entire HTTP message has been read successfully (not only on cancellation).