Skip to content

CXXCBC-525: Columnar - open cluster connection in background#621

Merged
avsej merged 1 commit intocouchbase:mainfrom
thejcfactor:CXXCBC-525
Jul 10, 2024
Merged

CXXCBC-525: Columnar - open cluster connection in background#621
avsej merged 1 commit intocouchbase:mainfrom
thejcfactor:CXXCBC-525

Conversation

@thejcfactor
Copy link
Copy Markdown
Contributor

Motivation

Columnar SDKs takes a different approach to connect. So that wrapper SDKs can still utilize the majority of the I/O functionality in the C++ client, the Columnar connect changes should be added.

Changes

  • Add path to allow SDKs to open and bootstrap a cluster in the background
  • Add "infinite" retries when bootstrapping
  • Add config_tracker
  • Add functionality to track bootstrap failure/success
  • Add deferred queue for HTTP requests

@thejcfactor thejcfactor requested review from DemetrisChr and avsej and removed request for DemetrisChr July 9, 2024 03:04
Comment thread CMakeLists.txt
Copy link
Copy Markdown
Member

@avsej avsej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good. I would merge it if tests pass and CI had some verification for COUCHBASE_CXX_CLIENT_COLUMNAR=ON in the matrix

@thejcfactor thejcfactor force-pushed the CXXCBC-525 branch 4 times, most recently from 05e32c5 to b9f31e8 Compare July 10, 2024 04:05
@thejcfactor thejcfactor marked this pull request as ready for review July 10, 2024 04:06
@thejcfactor thejcfactor requested a review from avsej July 10, 2024 04:06
Comment thread core/cluster.cxx
Comment thread core/http_component.cxx Outdated
Comment thread core/http_component.cxx Outdated
Motivation
==========
Columnar SDKs takes a different approach to connect.
So that wrapper SDKs can still utilize the majority of the I/O
functionality in the C++ client, the Columnar connect changes should be
added.

Changes
=======
* Add path to allow SDKs to open and bootstrap a cluster in the
  background
* Add "infinite" retries when bootstrapping
* Add config_tracker
* Add functionality to track bootstrap failure/success
* Add deferred queue for HTTP requests
@avsej avsej merged commit befbced into couchbase:main Jul 10, 2024
@thejcfactor thejcfactor deleted the CXXCBC-525 branch July 11, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants