Skip to content

CXXCBC-547: Add initial columnar query core implementation#616

Merged
DemetrisChr merged 1 commit intocouchbase:mainfrom
DemetrisChr:CXXCBC-547-columnar
Jul 4, 2024
Merged

CXXCBC-547: Add initial columnar query core implementation#616
DemetrisChr merged 1 commit intocouchbase:mainfrom
DemetrisChr:CXXCBC-547-columnar

Conversation

@DemetrisChr
Copy link
Copy Markdown
Contributor

@DemetrisChr DemetrisChr commented Jul 3, 2024

Motivation

Add core implementation for columnar queries

Changes

  • Add a columnar agent, providing access to all columnar-related operations. The columnar agent is the equivalent of "cluster agent" in the columnar side of things.
  • Add a columnar query component, that supports executing queries and streaming the results.
  • Add a high level row_streamer interface, that can be reused for different operations that stream rows (e.g. FTS, query, analytics). The row streamer allows reading the body header before returning from the operation i.e. the part of the body before the rows JSON array.
  • Add an http_streaming_response that can wrap the http_session and provide access to the body using pull-based streaming. It also makes it possible to stop the HTTP session mid-stream. Add support in http_session for returning the http_streaming_response.

Results

All tests pass

Further work is required to properly handle errors, return richer error information & add support for retries.

@DemetrisChr DemetrisChr force-pushed the CXXCBC-547-columnar branch 2 times, most recently from c0d89c8 to f2ff444 Compare July 3, 2024 15:34
@DemetrisChr DemetrisChr force-pushed the CXXCBC-547-columnar branch from f2ff444 to c461ca9 Compare July 3, 2024 15:52
Copy link
Copy Markdown
Member

@avsej avsej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Lets merge it and continue

@DemetrisChr DemetrisChr merged commit 9dcd044 into couchbase:main Jul 4, 2024
@DemetrisChr DemetrisChr deleted the CXXCBC-547-columnar branch July 4, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants