Skip to content

Finalize transaction_get_result API#597

Merged
avsej merged 1 commit intocouchbase:mainfrom
DemetrisChr:txns-get-result
Jun 18, 2024
Merged

Finalize transaction_get_result API#597
avsej merged 1 commit intocouchbase:mainfrom
DemetrisChr:txns-get-result

Conversation

@DemetrisChr
Copy link
Copy Markdown
Contributor

@DemetrisChr DemetrisChr commented Jun 18, 2024 •
edited
Loading

  • Remove content() overloads that are not in spec.
  • Rename content to content_as
  • Rename key() to id()
  • Make bucket/scope/collection accessors private

@DemetrisChr DemetrisChr requested a review from avsej June 18, 2024 18:31
@avsej avsej force-pushed the txns-get-result branch from 3e796c6 to 4fd615e Compare June 18, 2024 21:28
@avsej avsej force-pushed the txns-get-result branch from 4fd615e to e95f812 Compare June 18, 2024 22:10
@avsej avsej force-pushed the txns-get-result branch from e95f812 to 0e48482 Compare June 18, 2024 22:50
@avsej avsej merged commit 47644b6 into couchbase:main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avsej avsej avsej approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DemetrisChr @avsej