CXXCBC-517: Add HTTP session retries#589
Merged
avsej merged 2 commits intocouchbase:mainfrom Jun 14, 2024
Merged
Conversation
Contributor
Author
|
I will update CXXCBC-517 tomorrow w/ details from my testing. |
avsej
reviewed
Jun 13, 2024
Motivation ========== The client does not currently attempt to retry if the HTTP session fails to resolve or connect. Adding retries will help to improve user experience. Changes ======= * Add retries if resolve or connect fails. * If connect fails, and resolve provided multiple endpoints, attempt to connect to next endpoint in list of provided endpoints. * If ping() fails due to resolve/connect issue, list "attempted" hostname and port in `remote_address` property of `endpoint_ping_info`
Contributor
Author
|
Have updated CXXCBC-517 with logs and details around the testing 👍 |
avsej
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The client does not currently attempt to retry if the HTTP session fails to resolve or connect. Adding retries will help to improve user experience.
Changes
remote_addressproperty ofendpoint_ping_info