CXXCBC-523: Clean up dump_configuration config output#577
Merged
thejcfactor merged 2 commits intocouchbase:mainfrom Jun 10, 2024
Merged
CXXCBC-523: Clean up dump_configuration config output#577thejcfactor merged 2 commits intocouchbase:mainfrom
thejcfactor merged 2 commits intocouchbase:mainfrom
Conversation
Motivation ========== Being able to dump the cluster configuration is a useful debugging tool. An unfortunate side effect is the config is not properly trimmed when prepped to output in the log. Removing the unwanted bytes in the log helps improve dev experience. Changes ======= * Update cmd_cluster_map_change_notification and cmd_get_cluster_config to save parsed config body as std::string_view. * Update mcbp session to use new config_text from corresponding request/response.
avsej
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Being able to dump the cluster configuration is a useful debugging tool. An unfortunate side effect is the config is not properly trimmed when prepped to output in the log. Removing the unwanted bytes in the log helps improve dev experience.
Changes