CXXCBC-510: Support binary objects in transactions#576
Merged
avsej merged 1 commit intocouchbase:mainfrom Jun 11, 2024
Merged
Conversation
Member
Author
|
Several FIT tests still failing, in particular
|
avsej
force-pushed
the
CXXCBC-510-binary-transactions
branch
2 times, most recently
from
d7a2477 to
b18f470
Compare
avsej
force-pushed
the
CXXCBC-510-binary-transactions
branch
2 times, most recently
from
637b7da to
0b24861
Compare
Member
Author
|
Right now tests fail to compile, this is due to the main test coverage is done by FIT. I'm going to update unit tests tomorrow. But the implementation is complete now. |
avsej
force-pushed
the
CXXCBC-510-binary-transactions
branch
17 times, most recently
from
e40f39d to
06a5f18
Compare
avsej
force-pushed
the
CXXCBC-510-binary-transactions
branch
from
25f4a27 to
767300e
Compare
brett19
requested changes
Jun 11, 2024
Member
brett19
left a comment
brett19
left a comment
There was a problem hiding this comment.
Tests should be fixed before merging.
avsej
force-pushed
the
CXXCBC-510-binary-transactions
branch
2 times, most recently
from
145e0b7 to
bb8b875
Compare
brett19
previously approved these changes
Jun 11, 2024
avsej
force-pushed
the
CXXCBC-510-binary-transactions
branch
from
bb8b875 to
5b485c0
Compare
avsej
force-pushed
the
CXXCBC-510-binary-transactions
branch
from
5b485c0 to
15c488d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.