CXXCBC-508 Change connect, ping, diagnostics to use couchbase::error#567
Merged
Matt-Woz merged 4 commits intocouchbase:CXXCBC-496-errorfrom May 21, 2024
Conversation
DemetrisChr
reviewed
May 20, 2024
DemetrisChr
reviewed
May 20, 2024
DemetrisChr
reviewed
May 20, 2024
DemetrisChr
reviewed
May 20, 2024
DemetrisChr
reviewed
May 20, 2024
DemetrisChr
reviewed
May 20, 2024
DemetrisChr
requested changes
May 20, 2024
Contributor
DemetrisChr
left a comment
DemetrisChr
left a comment
There was a problem hiding this comment.
Looks good, just need to replace anywhere where only the message of the error is logged to logging the entire string representation of the error.
DemetrisChr
approved these changes
May 21, 2024
avsej
added a commit
that referenced
this pull request
May 27, 2024
…rror (#570) * CXXCBC-499 Use couchbase::error for Query, Search and Analytics operations (#557) * CXXCBC-492: Use couchbase::error for KV APIs (#562) * CXXCBC-498 Use couchbase:error for management operations (#560) * CXXCBC-500 Use couchbase::error for transactions (#564) * CXXCBC-508 Change connect, ping, diagnostics to use couchbase::error (#567) --------- Co-authored-by: Mateusz <[email protected]> Co-authored-by: Dimitris Christodoulou <[email protected]> Co-authored-by: Sergey Avseyev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes