Skip to content

CXXCBC-492: Use couchbase::error for KV APIs#562

Merged
Matt-Woz merged 1 commit intocouchbase:CXXCBC-496-errorfrom
DemetrisChr:CXXCBC-497-kv-error
Apr 24, 2024
Merged

CXXCBC-492: Use couchbase::error for KV APIs#562
Matt-Woz merged 1 commit intocouchbase:CXXCBC-496-errorfrom
DemetrisChr:CXXCBC-497-kv-error

Conversation

@DemetrisChr
Copy link
Copy Markdown
Contributor

No description provided.

@DemetrisChr DemetrisChr requested a review from Matt-Woz April 17, 2024 11:35
Copy link
Copy Markdown
Contributor

@Matt-Woz Matt-Woz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor changes

Comment thread couchbase/fmt/error_context.hxx Outdated
Comment thread couchbase/fmt/error.hxx Outdated
Comment thread couchbase/fmt/error_context.hxx Outdated
Comment thread examples/async_game_server.cxx Outdated
Comment thread test/test_integration_crud.cxx Outdated
@DemetrisChr DemetrisChr force-pushed the CXXCBC-497-kv-error branch from 5fbe29e to 1a503fd Compare April 24, 2024 14:45
Copy link
Copy Markdown
Contributor

@Matt-Woz Matt-Woz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Matt-Woz Matt-Woz merged commit 1ee4d3c into couchbase:CXXCBC-496-error Apr 24, 2024
avsej added a commit that referenced this pull request May 27, 2024
…rror (#570)

* CXXCBC-499 Use couchbase::error for Query, Search and Analytics operations (#557)

* CXXCBC-492: Use couchbase::error for KV APIs (#562)

* CXXCBC-498 Use couchbase:error for management operations (#560)

* CXXCBC-500 Use couchbase::error for transactions (#564)

* CXXCBC-508 Change connect, ping, diagnostics to use couchbase::error (#567)

---------
Co-authored-by: Mateusz <[email protected]>
Co-authored-by: Dimitris Christodoulou <[email protected]>
Co-authored-by: Sergey Avseyev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants