Merged
Conversation
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
pracucci
approved these changes
Feb 26, 2021
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
I'm good with the copy, especially considering this may reduce the blast radius of issues we may potentially introduce with this upgrade (gRPC and etcd). I just left a comment about package naming.
|
|
||
| package naming | ||
|
|
||
| // Copied from https://github.com/grpc/grpc-go/tree/v1.29.x/naming. |
Contributor
There was a problem hiding this comment.
What do you think to copy all these files to pkg/util/grpc/naming to make it more clear it's about grpc?
Contributor
Author
There was a problem hiding this comment.
Makes sense, I'll move the package.
Signed-off-by: Jacob Lisi <[email protected]>
Contributor
|
This brings in at least one optimisation from gRPC: grpc/grpc-go#3568 (should be visible in streaming queries, also in hand-over from one ingester to another which I for one don't run any more). Please look out for any differences visible in your dashboards, and consider including in CHANGELOG. |
yvrhdn
pushed a commit
to yvrhdn/tempo
that referenced
this pull request
Jul 12, 2021
ETCD has been updated here: cortexproject/cortex#3884
yvrhdn
pushed a commit
to yvrhdn/tempo
that referenced
this pull request
Jul 13, 2021
ETCD has been updated here: cortexproject/cortex#3884
yvrhdn
pushed a commit
to yvrhdn/tempo
that referenced
this pull request
Jul 15, 2021
ETCD has been updated here: cortexproject/cortex#3884
joe-elliott
pushed a commit
to grafana/tempo
that referenced
this pull request
Jul 15, 2021
* Upgrade Cortex to latest release v1.9.0 * Don't set CompressResponses as this is a no-op CompressResponses has been removed in v1.9.0 of Cortex. Additionally, this setting actually did not change anything when used in Tempo. In Cortex this setting was used when creating the handler in query-frontend: https://github.com/cortexproject/cortex/blob/4afaa357469fb37fd92cb1e2a0c1d10cdddc5ecd/pkg/cortex/modules.go#L557-L559 Since we do not use this code and have our own initialisation code for query-frontend, this setting never changed anything. * Update github.com/go-openapi, match with prometheus/alertmanager * Bump golangci-lint * Check in all vendor files (some were ignored for some reason?) * Update GRPC as ETCD has been updated in Cortex ETCD has been updated here: cortexproject/cortex#3884 * make vendor-check * Drop unnecessary replace statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
v1.32.0etcdimports to match the new etcd module packagesnamingnaming package that was deprecated topkg/util/namingto ensure no changes to behavior are introduced. I may be wrong but I don't think upstreamgrpclibrary provides a resolver interface that meets our use case anymore and we may be better off rolling our own implementation. I am open to suggestion on whether porting is the right approach.Which issue(s) this PR fixes:
Fixes #2015
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]