Module needs to wait for services from all of its dependencies.#3551
Merged
pstibrany merged 4 commits intocortexproject:masterfrom Dec 1, 2020
pstibrany:service-dependencies
Merged
Module needs to wait for services from all of its dependencies.#3551pstibrany merged 4 commits intocortexproject:masterfrom pstibrany:service-dependencies
pstibrany merged 4 commits intocortexproject:masterfrom
pstibrany:service-dependencies
Conversation
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR fixes initialization order of Cortex internal module services. Recently introduced "queryable" (internal) module broke initialization of "querier", because "queryable" doesn't have any service that "querier" could wait for. But "querier" should really wait for all services that "queryable" depends on. This PR does that.
Which issue(s) this PR fixes:
Fixes #3550
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]