Validate block range periods config in the compactor#3534
Conversation
Signed-off-by: Marco Pracucci <[email protected]>
I'd like to understand what you mean. Can you elaborate please? |
Yes, definitely. I've been too cryptic. Let's pick my real case: I configure the block ranges as |
WDYT? |
Thanks for explanation. That makes sense. I would perhaps expect to see compactor making 35 days block instead (also not what we really want, but closer to 30 than 7 :)). Extra check will set the expectations right. |
What this PR does:
Running a compactor with block range periods which are non divisible is not an issue per se, but doesn't bring the result the user may expect. To avoid mistakes, I would suggest to take a bold position in this case and do not allow block range periods which are not divisible by the previous one. I got tricked by this too and I would prefer to avoid our users get tricked too.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]