Move signal handling out of Server module.#2576
Merged
pstibrany merged 5 commits intocortexproject:masterfrom May 14, 2020
pstibrany:signal-handling
Merged
Move signal handling out of Server module.#2576pstibrany merged 5 commits intocortexproject:masterfrom pstibrany:signal-handling
pstibrany merged 5 commits intocortexproject:masterfrom
pstibrany:signal-handling
Conversation
Signed-off-by: Peter Štibraný <[email protected]>
This simplifies module service setup, we no longer need to make a distinction between services when using the wrapper or not. Signed-off-by: Peter Štibraný <[email protected]>
1 task
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
approved these changes
May 12, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Good job, LGTM! I left a couple of nits
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates latest version of weaveworks/common library, which allows Cortex to disable signal handling in
Servermodule.This simplifies module service setup, as we no longer need to make a distinction between services when using the wrapper or not. This also simplifies PR #2559.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]