This is particularly slow when running on OSX (with Docker for Mac) due to the shared volumes performances. Do you see any problem adding :delegated to the 3 related volumes, switching

	@$(SUDO) time docker run $(RM) $(TTY) -i \
		-v $(shell pwd)/.cache:/go/cache \
		-v $(shell pwd)/.pkg:/go/pkg \
		-v $(shell pwd):/go/src/github.com/cortexproject/cortex \
		$(BUILD_IMAGE) $@;

to

	@$(SUDO) time docker run $(RM) $(TTY) -i \
		-v $(shell pwd)/.cache:/go/cache:delegated \
		-v $(shell pwd)/.pkg:/go/pkg:delegated \
		-v $(shell pwd):/go/src/github.com/cortexproject/cortex:delegated \
		$(BUILD_IMAGE) $@;

In my case, the execution time difference is:

• Current: 8m8.369s
• With delegated: 1m38.258s

What does :delegated do?
Would we want it on all similar lines?

What does :delegated do?

The :delegated tells Docker for Mac that the container’s view is authoritative (permit delays before updates on the container appear in the host). Details here: https://docs.docker.com/docker-for-mac/osxfs-caching/

I don't have a Linux box right now to play with, but it should just be ignored on Linux.

Would we want it on all similar lines?

I would say yes.

Have you considered adding :delegated to volume mounts?

Have done this now.

I think go vet is on by default. We use it on Loki.

govet (vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: true, auto-fix: false]

see https://github.com/golangci/golangci-lint#quick-start

I did this test: change a printf format string to invalid, e.g. %i.
I get a warning from go vet but not from golangci-lint.
So I am un-convinced.

Interesting I have the same issue in loki but if I ran it for the specific package it works. Tried to clean my cache also using golangci-lint cache clean.

This is failing golangci-lint run -v ./pkg/querier/queryrange

but not

golangci-lint run -v ./...

Found the issue on Loki side, one file was producing warning.

WARN [runner] Can't run linter goanalysis_metalinter: misspell: can't get file /Users/ctovena/go/src/github.com/grafana/loki/pkg/logql/pkg/logql/expr.y contents: can't read file /Users/ctovena/go/src/github.com/grafana/loki/pkg/logql/pkg/logql/expr.y: open /Users/ctovena/go/src/github.com/grafana/loki/pkg/logql/pkg/logql/expr.y: no such file or directory

This was caused by a comment //line expr.y, I cleanup the file and it now catches %i in fmt.

FYI it was also causing some linter to be skipped.

You have the same kind of warning.

WARN [runner] Can't run linter goanalysis_metalinter: fact_purity: failed prerequisites: [email protected]/cortexproject/cortex/pkg/chunk [github.com/cortexproject/cortex/pkg/chunk/cache.test] 

Not sure why the exit code is not 1.

I found various issues relating to this - golangci/golangci-lint#866, golangci/golangci-lint#827