Repository navigation
Commit 410c1bd
committed
fix(rpc): -1 never-expires sentinel for cacheTtlMs/cacheRemainingMs
Post-merge review on #245 (cubic): collapsing the never-lane to 0 made a
warm lane numerically indistinguishable from a fresh/expired one for any
consumer that reads the numeric fields without the cacheNeverExpires
flag. -1 discriminates by value alone (falsy-value contract: -1 never /
0 expired-or-unset / N live), documented on the wire type. Pi's dialog
is in-process (no JSON boundary) and legitimately keeps Infinity.1 parent 8e496b8 commit 410c1bd
3 files changed
Lines changed: 24 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
487 | 487 | | |
488 | 488 | | |
489 | 489 | | |
490 | | - | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
491 | 495 | | |
492 | | - | |
| 496 | + | |
493 | 497 | | |
494 | 498 | | |
495 | 499 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
736 | 736 | | |
737 | 737 | | |
738 | 738 | | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
739 | 745 | | |
740 | | - | |
| 746 | + | |
741 | 747 | | |
742 | 748 | | |
743 | 749 | | |
744 | 750 | | |
745 | | - | |
746 | | - | |
747 | | - | |
| 751 | + | |
748 | 752 | | |
749 | 753 | | |
750 | 754 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
129 | 135 | | |
| 136 | + | |
| 137 | + | |
130 | 138 | | |
131 | 139 | | |
132 | | - | |
| 140 | + | |
| 141 | + | |
133 | 142 | | |
134 | 143 | | |
135 | 144 | | |
| |||
0 commit comments