Backport JDK-8048782: OpenJDK: PiscesCache : xmax/ymax rounding up can cause RasterFormatException#94
Merged
bernd-aws merged 1 commit intocorretto:developfrom Mar 21, 2019
Conversation
alvdavi
added a commit
to alvdavi/corretto-8
that referenced
this pull request
Jun 5, 2019
… rounding up can cause RasterFormatException (corretto#94)" This reverts commit 57da39c. This commit has caused rendering issues like corretto#127 and corretto#128 and will be reverted for 8u222
alvdavi
added a commit
to alvdavi/corretto-8
that referenced
this pull request
Jun 5, 2019
… rounding up can cause RasterFormatException (corretto#94)" This reverts commit 57da39c. This commit has caused rendering issues like corretto#127 and corretto#128 and will be reverted for 8u222
alvdavi
added a commit
to alvdavi/corretto-8
that referenced
this pull request
Jun 13, 2019
… rounding up can cause RasterFormatException (corretto#94)" This reverts commit 57da39c. This commit has caused rendering issues like corretto#127 and corretto#128 and will be reverted for 8u222
bernd-aws
pushed a commit
that referenced
this pull request
Jun 13, 2019
alvdavi
added a commit
to alvdavi/corretto-8
that referenced
this pull request
Jun 18, 2019
… rounding up can cause RasterFormatException (corretto#94)" This reverts commit 57da39c.
bernd-aws
pushed a commit
that referenced
this pull request
Jul 18, 2019
|
As a result of the revert, this bug fix is contained in Corretto 8.212 but not in 8.222 or 8.232. And this is not even mentioned in the change log. Will there be a replacement for the fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference to issue: #93
Describe the bug
JDK-8048782 describes an issue where sun.java2d.pisces.PiscesCache constructor that accepts min/max x and y arguments - the internal 'bboxX1' and 'bboxY1' are set to values one greater than given maximum X and Y values. This effectively causes an "off by 1" error.
The fix has already been backported to OpenJDK9 and should also be brought back to OpenJDK8 as we've experienced this issue first hand.
References:
https://bugs.openjdk.java.net/browse/JDK-8048782
http://mail.openjdk.java.net/pipermail/2d-dev/2014-June/004652.html
To Reproduce
An sample application in the JBS issue is available, along with a JTREG test in the patch.
Expected behavior
The sample program and JTREG should pass.
Platform information
All supported platforms and OS versions.
Additional context
Although this has been back ported in OpenJDK8 and will be available for u222 we have experienced this issue first hand and need to be pro-active in making this fix available now.