Skip to content

CI failure for testGroupPermission#4

Merged
corneadoug merged 1 commit intocorneadoug:Refactor/navbarCtrlfrom
prabhjyotsingh:logoutUserFix
Aug 8, 2016
Merged

CI failure for testGroupPermission#4
corneadoug merged 1 commit intocorneadoug:Refactor/navbarCtrlfrom
prabhjyotsingh:logoutUserFix

Conversation

@prabhjyotsingh
Copy link
Copy Markdown

Selenium was failing as it was not able to get "logout()", since the name is now changed to "navbar.logout()"

@corneadoug
Copy link
Copy Markdown
Owner

@prabhjyotsingh Thanks, I wasn't looking at that part of the test, and I couldn't reproduce the failure locally.

@corneadoug corneadoug merged commit 31f9110 into corneadoug:Refactor/navbarCtrl Aug 8, 2016
@prabhjyotsingh prabhjyotsingh deleted the logoutUserFix branch August 8, 2016 16:23
corneadoug added a commit that referenced this pull request Aug 9, 2016
### What is this PR for?
This is a small refactoring to keep this Controller following the [ControllerAs with vm](https://github.com/johnpapa/angular-styleguide/tree/master/a1#controlleras-with-vm)
rules, that it was based on.

Here is a list of things that were changed and why:

* Most of the controller's $scope values & fct (except from the search q) where moved to the vm.The controller is using vm, so storing in $scope to share with the view is not needed.

* Functions or Vars that are not used in the view were removed from the vm. (kept private to the controller)

* $rootscope functions was moved to `app.js`. I think  the need for that function might need to be changed, but for the scope of this PR, we are just moving it to where the $rootScope values are declared.

* Gathering vm declaration before the functions and ordered alphabetically

* Re-order functions alphabetically

* Create `initController ` to regroup all the controller setup.

### What type of PR is it?
Refactoring

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1290

### How should this be tested?
You can Just verify that the below Navbar related features are still good:
* Search Form
* Connected Status
* Login button
* User Name and its dropdown menu
* Notebook list drop-down menu (and filer, folder inside of it)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Damien CORNEAU <[email protected]>
Author: CORNEAU Damien <[email protected]>
Author: Prabhjyot Singh <[email protected]>

Closes apache#1281 from corneadoug/Refactor/navbarCtrl and squashes the following commits:

31f9110 [CORNEAU Damien] Merge pull request #4 from prabhjyotsingh/logoutUserFix
4686a18 [Prabhjyot Singh] CI failure for testGroupPermission
2fde749 [Damien CORNEAU] finish cleaning the controller
be18547 [Damien CORNEAU] Remove  functions from navbar controller
corneadoug pushed a commit that referenced this pull request Aug 16, 2016
### What is this PR for?
Adding extra libraries to livy interpreter which isn't exist by default.

### What type of PR is it?
[ Improvement ]

### Todos
* [Test case ] - Task

### What is the Jira issue?
*  [ZEPPELIN-1258]

### How should this be tested?
- Create new livy interpreter or modify the default.
- Set `livy.spark.jars.packages` to list of maven coordinates of jars. The format for the coordinates should be groupId:artifactId:version.

### Screenshots (if appropriate)
![](https://s31.postimg.org/px78l7ql7/Screenshot_from_2016_08_03_16_59_00.png)
![](https://s32.postimg.org/96ucb5rb9/Screenshot_from_2016_08_03_17_00_30.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes

Author: mahmoudelgamal <[email protected]>
Author: mfelgamal <[email protected]>
Author: Fouad <[email protected]>

Closes apache#1255 from mfelgamal/feature/modifying-livy-doc and squashes the following commits:

5411a2f [mahmoudelgamal] changeing default to example
d7f6818 [mahmoudelgamal] Adding livy.spark.jars.packages property
98090ab [mahmoudelgamal] Adding external libraries to livy
03a1e80 [mfelgamal] Merge pull request #4 from apache/master
2586651 [Fouad] Merge pull request #2 from apache/master
corneadoug pushed a commit that referenced this pull request Sep 27, 2016
## What is this PR for?
The PR is a interpreter for [Apache Beam](http://beam.incubator.apache.org) which is an open source unified platform for data processing pipelines. A pipeline can be build using one of the Beam SDKs.
The execution of the pipeline is done by different Runners . Currently, Beam supports Apache Flink Runner, Apache Spark Runner, and Google Dataflow Runner.

### What type of PR is it?
- Feature

### Todos
* Test case
* Review Comments
* Documentation

### What is the Jira issue?
* [ZEPPELIN-682]

### How should this be tested?
- Start the Zeppelin server
- The prefix of interpreter is `%beam` and then write your code with required imports and the runner

### Screenshots (if appropriate)
![](https://s9.postimg.org/s6eiwrbxb/beam_interpreter.png)
![](https://s9.postimg.org/eq3h8wsrz/visualisation_with_table.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes

Author: mahmoudelgamal <[email protected]>
Author: mfelgamal <[email protected]>
Author: Fouad <[email protected]>

Closes apache#1334 from mfelgamal/beam-interpreter-static-repl-7 and squashes the following commits:

da66c27 [mahmoudelgamal] Modify condition of checking static modifier
55c1322 [mahmoudelgamal] set spark version to 1.6.2 and throw original exception
27d7690 [mahmoudelgamal] set spark version to 1.6.1 and some modifications
750041c [mahmoudelgamal] Add readme file and modify pom file and travis.yml
ca88f94 [mahmoudelgamal] edit pom file and .travis.yml
3d65427 [mahmoudelgamal] update .travis.yml file
f19f98d [mahmoudelgamal] Make easy example with imports ands some modifications
74c14ca [mahmoudelgamal] Update the licenses
acc7afb [mahmoudelgamal] Change beam to version 0.2.0
e821614 [mahmoudelgamal] Removing hadoop-core and print stack trace to failure
5cb7c7b [mahmoudelgamal] Add some changes to doc and pom file
75fc4f7 [mahmoudelgamal] add interpreter to navigation.html and remove extra spaces and lines
9b1b385 [mahmoudelgamal] put beam in alphabetical order
9c1e25d [mahmoudelgamal] Adding changes like logging and conventions and license
2aa6d65 [mahmoudelgamal] changing class name to StaticRepl and adding some modifications
7cf25fb [mahmoudelgamal] Adding some tests
3c5038f [mahmoudelgamal] Modifying the documentation
5695077 [mahmoudelgamal] Modifying pom file and Making documentation
26fc59b [mahmoudelgamal] Refactoring of the code
3a2bd85 [mahmoudelgamal] Adding the beam to zeppelin 7
ab7ee2d [mahmoudelgamal] beam interpreter
85957ff [mfelgamal] Merge pull request apache#10 from apache/master
852c3d3 [mfelgamal] Merge pull request apache#9 from apache/master
a4bcc0d [mfelgamal] Merge pull request apache#8 from apache/master
858f1e1 [mfelgamal] Merge pull request apache#7 from apache/master
03a1e80 [mfelgamal] Merge pull request #4 from apache/master
2586651 [Fouad] Merge pull request #2 from apache/master
corneadoug added a commit that referenced this pull request Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants