libn/networkdb: take most tests off flaky list

corhere · corhere · commit 697c17ca955b · 2025-05-07T11:51:29.000-04:00
The loopback-test fixes seem to be sufficient to resolve the flakiness
of all the tests aside from TestFlakyNetworkDBIslands.

Signed-off-by: Cory Snider &lt;csnider@mirantis.com&gt;
diff --git a/libnetwork/networkdb/networkdb_test.go b/libnetwork/networkdb/networkdb_test.go
@@ -246,7 +246,7 @@ func TestNetworkDBJoinLeaveNetworks(t *testing.T) {
 	closeNetworkDBInstances(t, dbs)
 }
 
-func TestFlakyNetworkDBCRUDTableEntry(t *testing.T) {
+func TestNetworkDBCRUDTableEntry(t *testing.T) {
 	dbs := createNetworkDBInstances(t, 3, "node", DefaultConfig())
 
 	err := dbs[0].JoinNetwork("network1")
@@ -276,7 +276,7 @@ func TestFlakyNetworkDBCRUDTableEntry(t *testing.T) {
 	closeNetworkDBInstances(t, dbs)
 }
 
-func TestFlakyNetworkDBCRUDTableEntries(t *testing.T) {
+func TestNetworkDBCRUDTableEntries(t *testing.T) {
 	dbs := createNetworkDBInstances(t, 2, "node", DefaultConfig())
 
 	err := dbs[0].JoinNetwork("network1")
@@ -346,7 +346,7 @@ func TestFlakyNetworkDBCRUDTableEntries(t *testing.T) {
 	closeNetworkDBInstances(t, dbs)
 }
 
-func TestFlakyNetworkDBNodeLeave(t *testing.T) {
+func TestNetworkDBNodeLeave(t *testing.T) {
 	dbs := createNetworkDBInstances(t, 2, "node", DefaultConfig())
 
 	err := dbs[0].JoinNetwork("network1")

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ func TestNetworkDBJoinLeaveNetworks(t *testing.T) {`
`246`	`246`	`closeNetworkDBInstances(t, dbs)`
`247`	`247`	`}`
`248`	`248`
`249`		`-func TestFlakyNetworkDBCRUDTableEntry(t *testing.T) {`
	`249`	`+func TestNetworkDBCRUDTableEntry(t *testing.T) {`
`250`	`250`	`dbs := createNetworkDBInstances(t, 3, "node", DefaultConfig())`
`251`	`251`
`252`	`252`	`err := dbs[0].JoinNetwork("network1")`
`@@ -276,7 +276,7 @@ func TestFlakyNetworkDBCRUDTableEntry(t *testing.T) {`
`276`	`276`	`closeNetworkDBInstances(t, dbs)`
`277`	`277`	`}`
`278`	`278`
`279`		`-func TestFlakyNetworkDBCRUDTableEntries(t *testing.T) {`
	`279`	`+func TestNetworkDBCRUDTableEntries(t *testing.T) {`
`280`	`280`	`dbs := createNetworkDBInstances(t, 2, "node", DefaultConfig())`
`281`	`281`
`282`	`282`	`err := dbs[0].JoinNetwork("network1")`
`@@ -346,7 +346,7 @@ func TestFlakyNetworkDBCRUDTableEntries(t *testing.T) {`
`346`	`346`	`closeNetworkDBInstances(t, dbs)`
`347`	`347`	`}`
`348`	`348`
`349`		`-func TestFlakyNetworkDBNodeLeave(t *testing.T) {`
	`349`	`+func TestNetworkDBNodeLeave(t *testing.T) {`
`350`	`350`	`dbs := createNetworkDBInstances(t, 2, "node", DefaultConfig())`
`351`	`351`
`352`	`352`	`err := dbs[0].JoinNetwork("network1")`