Skip to content

refactor: create 933140 and 933180 .ra files#4488

Merged
fzipi merged 9 commits into
coreruleset:mainfrom
Xhoenix:create-933140-933180-ra-file
Mar 10, 2026
Merged

refactor: create 933140 and 933180 .ra files#4488
fzipi merged 9 commits into
coreruleset:mainfrom
Xhoenix:create-933140-933180-ra-file

Conversation

@Xhoenix

@Xhoenix Xhoenix commented Mar 1, 2026

Copy link
Copy Markdown
Member

What

Create regex assembly files for rules 933140 and 933180

Why

Transition to .ra format before LTS release

@github-actions

github-actions Bot commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@Xhoenix
Xhoenix temporarily deployed to quantitative-testing-approval March 1, 2026 12:24 — with GitHub Actions Inactive
@Xhoenix
Xhoenix temporarily deployed to quantitative-testing-approval March 1, 2026 12:26 — with GitHub Actions Inactive
@Xhoenix
Xhoenix requested a review from theseion March 1, 2026 12:46
@Xhoenix Xhoenix changed the title refactor: create 933140 and 933180 regex assembly files refactor: create 933140 and 933180 .ra files Mar 1, 2026
fzipi added 2 commits March 1, 2026 20:39
Break the monolithic regex into named assemblies, defines,
and sequenced blocks for improved readability.
List each PHP stream wrapper on its own line with comments,
letting the toolchain handle regex optimization.
Comment thread rules/REQUEST-933-APPLICATION-ATTACK-PHP.conf
Comment thread rules/REQUEST-933-APPLICATION-ATTACK-PHP.conf
@Xhoenix
Xhoenix requested a review from a team March 5, 2026 07:31
@Xhoenix
Xhoenix disabled auto-merge March 5, 2026 14:15
@Xhoenix
Xhoenix enabled auto-merge March 5, 2026 14:15
@Xhoenix
Xhoenix requested a review from a team March 5, 2026 14:16
@fzipi
fzipi disabled auto-merge March 10, 2026 18:05
@fzipi
fzipi enabled auto-merge March 10, 2026 18:06
@Xhoenix

Xhoenix commented Mar 10, 2026

Copy link
Copy Markdown
Member Author

Approval from someone else is required.

@fzipi
fzipi added this pull request to the merge queue Mar 10, 2026
Merged via the queue into coreruleset:main with commit 4cc6a37 Mar 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants