fix(920280, 920300, 920310, 920311, 920320, 920330): should be block #4319
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
📊 Quantitative test results for language: |
touchweb-vincent
changed the title
EsadCetiner
requested changes
Nov 4, 2025
Member
EsadCetiner
left a comment
EsadCetiner
left a comment
There was a problem hiding this comment.
@touchweb-vincent the SecMarker is probably there to skip 920290 for performance reasons
There are a few more rules in this file that uses pass instead of block, can you update those too?
Contributor
Author
|
Done |
touchweb-vincent
changed the title
touchweb-vincent
changed the title
EsadCetiner
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This rule should block, IMO, and I think the marker isn’t necessary.