Skip to content

Conversation

@EsadCetiner
Copy link
Member

This PR tries to reduce false positives with the PHP response rules at both PL-1 and 2 by moving false positive prone entries to PL-2 and using word boundaries where possible to reduce false positives.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

📊 Quantitative test results for language: eng, year: 2023, size: 10K, paranoia level: 1:
🚀 Quantitative testing did not detect new false positives

@azurit
Copy link
Member

azurit commented Sep 26, 2025

This string can be removed:
Path cannot be empty

as it's covered by this:
cannot be empty

@EsadCetiner EsadCetiner force-pushed the fix-reduce-fps-php-response branch from 001300b to 3383de0 Compare September 26, 2025 07:55
@EsadCetiner
Copy link
Member Author

@azurit I ended up moving Path cannot be empty back to PL-1

@EsadCetiner EsadCetiner added this pull request to the merge queue Sep 26, 2025
Merged via the queue into coreruleset:main with commit b015ad4 Sep 26, 2025
7 checks passed
@EsadCetiner EsadCetiner deleted the fix-reduce-fps-php-response branch September 26, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants