fix: don't replace cmdline suffixes for 932220 and 932250 #4231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
📊 Quantitative test results for language: |
theseion
force-pushed
the
fix-932220-932250
branch
from
b3e2ca4 to
3dfb769
Compare
EsadCetiner
reviewed
Aug 10, 2025
Member
EsadCetiner
left a comment
EsadCetiner
left a comment
There was a problem hiding this comment.
I've just tested this locally and everything works as expected.
During the refactoring of the RCE rules and the "upto3" and "4andup" data files, rules 932220 and 932250 were changed to accidentally include data files without cmdline suffixes, even though both rules use the cmdline processor. This commit fixes both rules, making them process the cmdline suffixes as originally intended.
theseion
force-pushed
the
fix-932220-932250
branch
from
7c31351 to
9a04ced
Compare
EsadCetiner
approved these changes
Aug 19, 2025
Contributor
Member
|
@S0obi No, this fixes a bug where some suffixes aren't being applied correctly resulting in false negatives. I'll reference the PR in the issue when I have a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the refactoring of the RCE rules and the "upto3" and "4andup" data files, rules 932220 and 932250 were changed to accidentally include data files without cmdline suffixes, even thoug both rules use the cmdline processor. This commit fixes both rules, making them process the cmdline suffixes as originally intended.