feat: refresh restricted-upload.data #4046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
📊 Quantitative test results for language: |
Contributor
|
Thanks @S0obi, much appreciated! I don't think the list should loose any entries, unless there's an explicit reason. That would mean, porting the missing entries to |
S0obi
force-pushed
the
feature/refresh-restricted-upload.data
branch
from
9884ac2 to
3181976
Compare
S0obi
force-pushed
the
feature/refresh-restricted-upload.data
branch
from
3181976 to
1d22fe0
Compare
Contributor
Author
theseion
approved these changes
Mar 27, 2025
Contributor
|
Thanks. I'd like @EsadCetiner to also look through the changes. |
EsadCetiner
approved these changes
Mar 28, 2025
Contributor
|
Thank you for your very first contribution @S0obi! I hope it is just the first of many more :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear coreruleset community,
After browsing the list of issues, I found this one that I can help with and familiarize myself with the contribution process.
I will first propose to refresh this data file by fixing and executing again the legacy script that I downloaded from previous version of this repository. I sorted the list alphabetically, in order to help the reviewer, here is the list of new keywords and the ones removed :
Added ✅
Removed ❌
The second step will be to port this script in crs-toolchain by addressing issue coreruleset/crs-toolchain/issues/181
Refs: #3916