add FilesWithNames() to activation#497
Conversation
kolyshkin
left a comment
kolyshkin
left a comment
There was a problem hiding this comment.
It does not make sense to have two commits here, since the second one merely simplifies the issue you just added in the first one. IOW please squash these.
activation/files.go
Outdated
| @@ -0,0 +1,29 @@ | |||
| // Copyright 2015 CoreOS, Inc. | |||
There was a problem hiding this comment.
The copyright year should be 2025 since this code was written in 2025. Also, IANAL but the copyright holder should probably be Red Hat, Inc. (as Red Hat acquired CoreOS in 2018).
There was a problem hiding this comment.
looks like some other modules use both so I copied that.
activation/files.go
Outdated
| @@ -1,4 +1,5 @@ | |||
| // Copyright 2015 CoreOS, Inc. | |||
| // Copyright 2025 CoreOS, Inc. | |||
| // Copyright 2025 RedHat, Inc. | |||
There was a problem hiding this comment.
should we match the convention with the rest of the project or correct it here? https://github.com/search?q=repo%3Acoreos%2Fgo-systemd%20redhat&type=code
activation/files.go
Outdated
| @@ -1,4 +1,5 @@ | |||
| // Copyright 2015 CoreOS, Inc. | |||
| // Copyright 2025 CoreOS, Inc. | |||
There was a problem hiding this comment.
Also, there's no "CoreOS, Inc." any longer, that company got acquired by Red Hat in 2018 or so. IANAL but I guess you can omit this line, only leaving Red Hat one.
|
If you can fix the copyright and squash your commits I think this one LGTM |
MayCXC
force-pushed
the
activation-files-with-names
branch
from
c3f118d to
f97010a
Compare
2 participants
reopens #448 which had a broken actions runner.