Merged
Conversation
Luap99
approved these changes
Jan 21, 2026
Collaborator
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
LGTM, not a huge fan of how go generics look but the deduplication does indeed look quite nice here.
It looks like listUnitsInternal performs an unnecessary conversion from [][]any to []any. Also, its code has been copied over a few times, with the only change to resulting type. Introduce generic helper functions convertSlice and storeSlice to eliminate duplicated code. Also, remove unnecessary intermediate slice allocation and conversion. This change: - Adds convertSlice[T] to convert []any to typed slices - Adds storeSlice[T] to fetch and convert D-Bus results - Updates 9 functions to use the new helpers - Removes ~150 lines of duplicated code - Eliminates listUnitsInternal and listUnitFilesInternal wrappers All functionality is preserved and tests pass. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> Signed-off-by: Kir Kolyshkin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like
listUnitsInternalperforms an unnecessary conversion from[][]anyto[]any. Also, its code has been copied over a few times, with the only change to resulting type.Introduce generic helper functions convertSlice and storeSlice to eliminate duplicated code. Also, remove unnecessary intermediate slice allocation and conversion.
This change:
All functionality is preserved and tests pass.
Co-Authored-By: Claude Sonnet 4.5