dbus: fix TestSetUnitProperties wrt systemd >= 252#489
Merged
Luap99 merged 1 commit intocoreos:mainfrom Jan 6, 2026
Merged
Conversation
Since systemd 252, some cgroup v1 unit properties are fully deprecated and are ignored. This includes CPUShares that is used by TestSetUnitProperties. As a result, the test fails. Reproduced on Fedora 43 with systemd 258: # systemctl set-property -- '-.mount' CPUShares=1024 D-Bus property CPUShares is deprecated, ignoring assignment: CPUShares=1024 # systemctl show -- -.mount | grep Shares (no output) To fix the test failure, replace CPUShares with TasksMax, which is supported since systemd 227 and available for both cgroups v1 and v2. Signed-off-by: Kir Kolyshkin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since systemd 252, some cgroup v1 unit properties are fully deprecated and are ignored. This includes CPUShares that is used by TestSetUnitProperties. As a result, the test fails.
Reproduced on Fedora 43 with systemd 258:
To fix the test failure, replace CPUShares with TasksMax, which is supported since systemd 227 and available for both cgroups v1 and v2.